Skip to content

[19.0][MIG] commission_formula_oca: Migration to 19.0 - #679

Open
suker wants to merge 18 commits into
OCA:19.0from
zhintek:19.0-mig-commission_formula_oca
Open

suker wants to merge 18 commits into
OCA:19.0from
zhintek:19.0-mig-commission_formula_oca

Conversation

@suker

@suker suker commented Jun 15, 2026

Copy link
Copy Markdown

This PR migrates the commission_formula_oca module to Odoo version 19.0.

Changes:

  • Bump version to 19.0.1.0.0

andrel-exo and others added 17 commits June 15, 2026 23:07
Currently translated at 100.0% (14 of 14 strings)

Translation: commission-16.0/commission-16.0-commission_formula
Translate-URL: https://translation.odoo-community.org/projects/commission-16-0/commission-16-0-commission_formula/es/
Currently translated at 100.0% (14 of 14 strings)

Translation: commission-16.0/commission-16.0-commission_formula
Translate-URL: https://translation.odoo-community.org/projects/commission-16-0/commission-16-0-commission_formula/pt_BR/
Currently translated at 100.0% (15 of 15 strings)

Translation: commission-16.0/commission-16.0-commission_formula
Translate-URL: https://translation.odoo-community.org/projects/commission-16-0/commission-16-0-commission_formula/es/
Currently translated at 100.0% (15 of 15 strings)

Translation: commission-16.0/commission-16.0-commission_formula
Translate-URL: https://translation.odoo-community.org/projects/commission-16-0/commission-16-0-commission_formula/ca/
Currently translated at 100.0% (15 of 15 strings)

Translation: commission-17.0/commission-17.0-commission_formula
Translate-URL: https://translation.odoo-community.org/projects/commission-17-0/commission-17-0-commission_formula/es/
Currently translated at 100.0% (15 of 15 strings)

Translation: commission-17.0/commission-17.0-commission_formula
Translate-URL: https://translation.odoo-community.org/projects/commission-17-0/commission-17-0-commission_formula/it/
Currently translated at 100.0% (15 of 15 strings)

Translation: commission-17.0/commission-17.0-commission_formula
Translate-URL: https://translation.odoo-community.org/projects/commission-17-0/commission-17-0-commission_formula/pt_BR/
Currently translated at 93.3% (14 of 15 strings)

Translation: commission-17.0/commission-17.0-commission_formula
Translate-URL: https://translation.odoo-community.org/projects/commission-17-0/commission-17-0-commission_formula/tr/
Currently translated at 100.0% (15 of 15 strings)

Translation: commission-17.0/commission-17.0-commission_formula
Translate-URL: https://translation.odoo-community.org/projects/commission-17-0/commission-17-0-commission_formula/it/
Currently translated at 100.0% (15 of 15 strings)

Translation: commission-17.0/commission-17.0-commission_formula
Translate-URL: https://translation.odoo-community.org/projects/commission-17-0/commission-17-0-commission_formula/it/
@OCA-git-bot OCA-git-bot added series:19.0 mod:commission_formula_oca Module commission_formula_oca labels Jun 15, 2026
@suker suker mentioned this pull request Jun 15, 2026
8 tasks
@suker suker changed the title 19.0 mig commission formula oca [19.0][MIG] commission formula oca Jun 15, 2026
@suker
suker force-pushed the 19.0-mig-commission_formula_oca branch from acdd242 to 1b43093 Compare June 19, 2026 08:46

@BhaveshHeliconia BhaveshHeliconia left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review LGTM!

@BhaveshHeliconia

Copy link
Copy Markdown

@suker could you please update the title to: [19.0][MIG] commission_formula_oca: Migration to 19.0

@suker suker changed the title [19.0][MIG] commission formula oca [19.0][MIG] commission_formula_oca: Migration to 19.0 Jul 14, 2026

@rrebollo rrebollo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review. LGTM!

I've never seen the t-translation tag before. Interesting.

Hey, would you be so kind as to review my #676 in return?

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Comment thread commission_formula_oca/__manifest__.py Outdated
"author": "Abstract,Odoo Community Association (OCA)",
"website": "https://github.com/OCA/commission",
"depends": ["commission_oca", "account"],
"depends": ["account_commission_oca"],

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you changing the dependencies? Even more: in one moment, the dependencies were expanded to account, but the idea is that this module don't need account in any moment, just commission_oca.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, deps shouldn't have been changed.

I could also delete account from deps but that would affect to tests, is ok with it?

@pedrobaeza

Copy link
Copy Markdown
Member

/ocabot migration commission_formula_oca

@OCA-git-bot OCA-git-bot added this to the 19.0 milestone Sep 15, 2026
@pedrobaeza

Copy link
Copy Markdown
Member

I think the tests in this case should only check current methods, not a flow involving invoices.

@suker
suker force-pushed the 19.0-mig-commission_formula_oca branch from 1b43093 to ca1ba87 Compare September 16, 2026 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:commission_formula_oca Module commission_formula_oca series:19.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.